Closed grafakus closed 1 week ago
I think this looks great!
Also I think the "time picker" mode is kind of confusing and I would opt to remove that, but that is out of scope for this PR.
wdyt?
- let's make the "how" uncollapsed by default -- one less click for the user. without it being visibile by default we run the same issue of someone potentially missing it and not knowing what to do
Just my 2¢, but this is a double-edged sword. Having the section expanded by default will likely help newcomers understand how to use the diff view on their first impression. However beyond that, I expect an auto-expanded "how-to" like this would be extraordinarily annoying and disruptive beyond the first one or two page lands. Once a user understands the flow, prominently displaying a large gif on how to use the tool which you must scroll by or manually collapse will not be a great experience. This is definitely a trade-off between "good first experience" and "good general experience." Do we want to design for the new user or for the general user? I would recommend against an auto-expanded help, but I will not die on this hill.
I agree with Bryan, it's one more click for the user, once.
Let's try to make baby steps and divide & conquer. We can change and iterate later on.
@Rperry2174 for your 2nd suggestion, I'm working on https://github.com/grafana/explore-profiles/issues/200 and I'm also considering adding an "Auto-diff" button to simplify the flow.
Then we can add clear CTAs in the info banner so that the users have the choice to:
If none of these work well, we can consider auto-selecting by default, like the legacy plugin did.
✨ Description
Related issue(s): relates to https://github.com/grafana/explore-profiles/issues/224
This PR adds a collapsible section when landing on the "Diff flame graph" view and the user has not selected both flame graphs time ranges. The collapsed section includes an animated gif:
📖 Summary of the changes
The E2E screenshots have also been updated. See diff tab for specific comments.
🧪 How to test?
-