grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.
GNU Affero General Public License v3.0
18 stars 1 forks source link

[diff flame graph view] Auto-select should behave differently if the filters are different in baseline & comparison #243

Open grafakus opened 3 days ago

grafakus commented 3 days ago

Feature description

Is your feature request related to a problem? Please describe.

Context: this PR

Auto-select should not behave the same if there are different filters in baseline & comparison: if the filters are different, selecting the whole time range makes sense, if they are the same, selecting half of the range makes more sense.

Describe the solution you'd like

See above

Alternatives considered

A great suggestion from @Rperry2174 in https://github.com/grafana/explore-profiles/issues/224 is that "the auto-select button should pick the 5 minutes on either side of the lowest point on the baseline graph as the baseline.. the button should pick the 5 minutes on either side of the highest pint for the comparison". We should also consider it as an alternative or as another option in the UI.

Additional context

-