grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.

GNU Affero General Public License v3.0

18 stars 2 forks source link

fix(DiffView): Clicking on "Auto-select" selects a 25% range #254

Closed grafakus closed 3 weeks ago

grafakus commented 3 weeks ago

✨ Description

Related issue(s): fixes https://github.com/grafana/explore-profiles/issues/253

📖 Summary of the changes

See diff tab

🧪 How to test?

Manually:

clicking on "Auto-select" should always select a 25% range on both the baseline & the comparison time series
when the 25% are bigger than one day, the range should be capped to 1 day

github-actions[bot] commented 3 weeks ago

Unit test coverage

Lines	Statements	Branches	Functions
	12.34% (486/3937)	9.73% (136/1397)	8.88% (111/1249)

colega commented 3 weeks ago

Should we cap auto-select to an absolute value instead? Like 1d max. If I'm looking at 14d range, selecting a 25% of that still would be a lot.

Rperry2174 commented 3 weeks ago

Agreed let's do the minimum between 25% and 1 day that way when the time range is short we just do 25% but when it's long it gets capped at 1 day.

I love the fine tuning and feedback loop on this!

grafakus commented 3 weeks ago

Should we cap auto-select to an absolute value instead? Like 1d max. If I'm looking at 14d range, selecting a 25% of that still would be a lot.

Done!