search

grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.
GNU Affero General Public License v3.0
18 stars 1 forks source link

refactor(Tracking): Better error logging for Scenes variables #290

Closed grafakus closed 1 day ago

grafakus commented 2 days ago

✨ Description

Related issue(s): -

When a Scene variable encounters an error, the Scenes library only sets the error message in the variable state. This PR ensures we log an error with Faro, and not only the message.

Additionally, there's a of behaviour for the "Labels" view: we prevent the labels data source to fail when fetching label values fail.

📖 Summary of the changes

The logger calls are moved to the data sources instead of the React components. See diff tab for specific comments.

🧪 How to test?

-

github-actions[bot] commented 2 days ago

Unit test coverage

Lines Statements Branches Functions
Coverage: 13%
 13.59% (543/3994) 10.3% (147/1426) 9.88% (125/1265)