search

grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.
GNU Affero General Public License v3.0
17 stars 1 forks source link

feat(*): Revamp exploration type selector #94

Closed grafakus closed 1 month ago

grafakus commented 1 month ago

✨ Description

Related issue(s): -

Motivation: new users are confused about where they are and how they can navigate back (the browser back button doesn't work). This PR changes the styles of the exploration type selector to make this more obvious. Note that, this is more a "low hanging fruit" than a real improvement. We will address the fundamental issue once our UX research is more advanced.

Before After
image image

📖 Summary of the changes

See diff tab

🧪 How to test?

github-actions[bot] commented 1 month ago

Unit test coverage

Lines Statements Branches Functions
Coverage: 12%
 12.58% (470/3736) 9.82% (138/1404) 9.49% (108/1138)
Rperry2174 commented 1 month ago

I like this! I feel like this is the most important thing we want people to get from the app at first glance...

What if we make this on the top "row" by itself and then beneath we have datasource and service name next to each other?

grafakus commented 1 month ago

What if we make this on the top "row" by itself and then beneath we have datasource and service name next to each other?

The issue is that this part of the UI will start to feel a bit crowded/messy:

image

Also, once a data source is selected, the users will most likely play with the service and profile type selectors, so it makes sense to separate the data source selector on the UI IMO.