search

grafana / explore-profiles

Explore Profiles is a native Grafana application designed to integrate seamlessly with Pyroscope, the open-source continuous profiling platform, providing a smooth, query-less experience for browsing and analyzing profiling data.
GNU Affero General Public License v3.0
18 stars 1 forks source link

[bug] when I hit refresh button, the "Explain flamegraph" changes it's "new" badger color #99

Closed korniltsev closed 2 months ago

korniltsev commented 2 months ago

Bug description

When I hit refresh button, the "Explain flamegraph" changes it's "new" badger color from orange to gray and back This is distracting and unnecessary.

Steps to reproduce

Actual behaviour

Expected behaviour

The button does not blink and not distracts

korniltsev commented 2 months ago

Also flamegraph pane title adds "..." for some reason

Goes from "profiles-dev-003/ingester flame graph (cpu)" to "profiles-dev-003/ingester flame graph (cpu)..." and back to "profiles-dev-003/ingester flame graph (cpu)" This is not needed

grafakus commented 2 months ago

Two little things:

  1. We are going to remove the "new" badge, the feature is already a few months old. it's not new anymore :)
  2. The change of the button's color indicates a change of state state: it's disabled (grey) when loading new data. This is for visual feedback, to indicate to the user it's inactive.