The structural tab "Apply Full Traces" filter has unexpected behavior

grafana / explore-traces

Opinionated traces app

Apache License 2.0

17 stars 0 forks source link

Open joe-elliott opened 1 month ago

joe-elliott commented 1 month ago

If the structural tab reveals no data then it shows a button to "apply full traces" filter:

Upon clicking this the primary signal is changed from whatever it is to "Full Traces" and the other filters are left alone:

However the other filters could quite easily not apply to "full traces" leaving the entire app w/o data:

I think the simplest solution would be just to remove the "Apply Full Traces" button.

adrapereira commented 1 month ago

@nadinevehling

nadinevehling commented 1 month ago

Yeah, I agree this is confusing. Let's remove the CTA "to apply full traces". We keep the link to docs, the info text above, and the additional text.

FYI @joe-elliott We have a related issue here.