grafana / explore-traces

Opinionated traces app
Apache License 2.0
9 stars 0 forks source link

Comparison: Don't show redundant attributes when "Full Traces" is selected #240

Open joe-elliott opened 1 day ago

joe-elliott commented 1 day ago

When "full traces" is selected the rootName and name attributes should always be the same. Similarly the rootServiceName and resource.service.name should always be the same. This is because when "Full Traces" is selected we are using a filter to always select the root span.

Image

Image

My .02: Drop "rootName" and "rootServiceName" as I think the others are more clear in this situation. Note that we are looking to change these strings so the code should handle both the old and new values.

@mdisibio, Do you think there's any good way to just not scan/return this data tempo side? or should we just filter them app side?