search

grafana / faro-web-sdk

The Grafana Faro Web SDK, part of the Grafana Faro project, is a highly configurable web SDK for real user monitoring (RUM) that instruments browser frontend applications to capture observability signals. Frontend telemetry can then be correlated with backend and infrastructure data for full-stack observability.
https://grafana.com/oss/faro/
Apache License 2.0
688 stars 62 forks source link

adblockers create errors on browser console #497

Open petitkriket opened 4 months ago

petitkriket commented 4 months ago

Description

Capturing metrics with a cloud based instance floods console with errors because of the users adblockers

Steps to reproduce

  1. Add Faro to the project
  2. Send a metric to a Grafana.com cloud hosted instance using the Faro SDK
  3. See a error clogged browser console
  4. Disable adblocker
  5. Console is clean

Expected behavior

  1. Add Faro to the project
  2. Send a metric to a Grafana managed instance using the Faro API
  3. No error in the console while data is not sent and user trace is not sent
  4. No error in the console while data is sent because it's whitelisted to adblockers

Actual behavior

Console is full of errors which makes seeing actual bugs more difficult

Environment

Demo

Screenshot 2024-02-22 at 23 33 51

Context

grafana saas cloud domain is present on adblocker ban lists So I guess it would work fine on a self hosted Grafana but not on a managed one

eskirk commented 4 months ago

hi @petitkriket, thanks for the report.

we are aware of this issue and we have some solutions in mind to help circumvent this problem - as a user of ublock myself, I really want to fix this.

I do worry this may end up being a game of cat and mouse with easylist VS faro endpoints - especially since myself and the rest of the team fully respects the user's rights to limit whatever type of payloads their browser may be sending to endpoints across the internet.

I will check in on the progress of our solution and let you know when I know more.

petitkriket commented 4 months ago

thank for you swift reply ! totally agree with you on the matter of privacy. happy to know and not surprised that you're well aware of the issue, curious about the solution you and your team will pick !

the additional errors produced from the SDK creates unwanted noise IMO. a single warning would be a nice to have..

kind regards