search

grafana / faro-web-sdk

The Grafana Faro Web SDK, part of the Grafana Faro project, is a highly configurable web SDK for real user monitoring (RUM) that instruments browser frontend applications to capture observability signals. Frontend telemetry can then be correlated with backend and infrastructure data for full-stack observability.
https://grafana.com/oss/faro/
Apache License 2.0
739 stars 64 forks source link

feat(web-sdk): forward logArgsSerializer in initializeFaro to the core #589

Closed LeonEck closed 4 months ago

LeonEck commented 4 months ago

Why

https://github.com/grafana/faro-web-sdk/pull/580 introduced the logArgsSerializer option in the core. But it isn't usable through initializeFaro from the web-sdk since the makeCoreConfig doesn't forward the option.

What

I tried to follow the patterns of the surrounding code, which is why I introduced the new defaultLogArgsSerializer to use as a fallback. If logArgsSerializer is not set on the browser config this default is used.

I didn't find any documentation that could be updated alongside with this change. If there is a place I should document this, please let me know.

Checklist

codecapitano commented 4 months ago

Hi @LeonEck And thanks a lot for your contribution 🙏

I didn't find any documentation that could be updated alongside with this change. If there is a place I should document this, please let me know.

No worries, currently we only have the cloud docs for Faro which can only be changed internally. I'll take care of updating them.