search

grafana / gel-app

Experimental Grafana Backend Expressions/Transform Plugin (GEL)
Apache License 2.0
2 stars 1 forks source link

make plugin logger available to gelpoc pkg #60

Closed kylebrandt closed 4 years ago

ryantxu commented 4 years ago

as a general practice... do we need to create a new logger and pass it around? can we just use backend.Logger?

For the other plugins I have replaced all the code that manages copying the same logger from place to place and just uses the global one -- is that bad practice? I can't think of any reason to want multiple loggers (they all end up in the same place anyway)

kylebrandt commented 4 years ago

as a general practice... do we need to create a new logger and pass it around? can we just use backend.Logger?

For the other plugins I have replaced all the code that manages copying the same logger from place to place and just uses the global one -- is that bad practice? I can't think of any reason to want multiple loggers (they all end up in the same place anyway)

IMO, globals are bad practice, except for same cases, like a logger for a plugin :-) This was made before the global logger existed. If fact, this was more evidence to me that the global logger was a good idea. So don't want to merge this anymore, just a reminder to clean up logging, but using the global logger.