Closed gwdawson closed 12 months ago
zoltanbedi
commented
1 year ago Can we have the collapsed info on the top not to be collapsed by default? I also think that the old info box was more attention grabber. The radio button for the license doesn't really make sense for me.
Can we also have @catherineymgui or someone from UX to also review these changes?
gabor
commented
1 year ago @zoltanbedi the idea with the radio-button was to make the UI more explicit. the way it works right now is that you have to decide if you have enterprise-github (well, on-prem i guess) or normal-github, and based on that the field is either mandatory, or it must be empty. so i thought it's better that you have to apply that decision into choosing from two possibilities, and the UI adapts to that decision.
but i understand that it may not be the best solution, so we should iterate on that 👍
zoltanbedi
commented
12 months ago The collapsible info section at the top is still collapsed by default also in the doc the additional settings are collapsed. I'm still not fan of the radio button but I can live with that. we can try it out and see.
gwdawson
commented
12 months ago The collapsible info section at the top is still collapsed by default also in the doc the additional settings are collapsed. I'm still not fan of the radio button but I can live with that. we can try it out and see.
@zoltanbedi edited to made additional settings collapsible, also as requested above i have set the "Access Token Permissions" to be open by default.
catherineymgui
commented
12 months ago Hey sorry I was on PTO! Radio button list might make more sense if you wanted to iterate on this.
this pr updates the configuration to follow the best practices.
Partial #72761 Fixes #244
Before & After:
https://github.com/grafana/github-datasource/assets/34524710/19ff4584-e172-4840-a2db-9cb97e6f2529