search

grafana / github-datasource

Grafana data source plugin using the Github API to retrieve and visualize Github data.
https://grafana.com/grafana/plugins/grafana-github-datasource/
Apache License 2.0
242 stars 53 forks source link

Pull Requests: Add additional user fields #286

Closed rayfaddis closed 2 months ago

rayfaddis commented 8 months ago

Adds more user fields to Pull Requests:

  1. Authors name
  2. Merged by users name
  3. Merged by users login\username
  4. Merged by users email
  5. Merged by users company name
CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

rayfaddis commented 8 months ago

Hello, can I please get a build run approved for this? @zoltanbedi maybe that's a request to you?

rayfaddis commented 2 months ago

Hello @ivanahuckova! and thank you for the reply. I had updated pkg/github/testdata/pull_requests.golden.jsonc and didn't see any other tests areas or test data to update. If there is an area where I could have added more tests please let me know, I am new to go.

ivanahuckova commented 2 months ago

@rayfaddis oh yeah, you are correct. I thought we have some unit tests in pkg/github/pull_requests_test.go, but it seems that we use mainly snapshot tests. So feel free to ignore the part about the additional tests. 🙂