grafana / github-datasource

Grafana data source plugin using the Github API to retrieve and visualize Github data.
https://grafana.com/grafana/plugins/grafana-github-datasource/
Apache License 2.0
242 stars 53 forks source link

feature request: improve page-limits handling #302

Open gabor opened 5 months ago

gabor commented 5 months ago

we have some hardcoded page limits in the code, for example:

we should increase these, but if we increase them too much we'll hit rate limits. some ideas:

  1. make these user-configurable
  2. warn the user if they are trying to fetch too much data

(see https://github.com/grafana/github-datasource/pull/232 for more context)

natellium commented 3 months ago

I ran into this yesterday. The project I was querying has hundreds of closed issues, so no matter what I did I only got the first bunch. It also seems the filters are applied after the query, so I couldn't work around the limit either 😞

trevjonez commented 2 months ago

Possibly related given apps have much higher rate limits compared to a user PAT. https://github.com/grafana/github-datasource/issues/88

Another thing that could help is using the logged in users auth since that could scale better for concurrent users compared to using app auth

https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28