This PR includes couple of different things that I discovered while onboarding to a codebase. I am more than happy to break it down to separate PRs if needed.
Removes pkg/plugin/resource_handlers.go as functions and methods are not called from anywhere.
We could then remove package github.com/gorilla/mux, as it was used only in now removed resource_handlers.go and then it was added as indirect dependancy.
Adds comments to methods in DataSource.ts. I believe this is beneficial for us to understand where is what used, as some of these methods are part of DataSourceAPI and not called directly.
Removes async getLabels method as it wasn't called anywhere.
Adds LegacyMetricFindQueryOptions types and removes rangeRaw: options.rangeRaw, as it is always undefined as rangeRaw is not a part of LegacyMetricFindQueryOptions.
Removes ResetButton and LabelSelector components as they are not used anywhere
Brings visibility to dashboard.json for development. I tested it and it is a good dashboard.
This PR includes couple of different things that I discovered while onboarding to a codebase. I am more than happy to break it down to separate PRs if needed.
pkg/plugin/resource_handlers.go
as functions and methods are not called from anywhere.github.com/gorilla/mux
, as it was used only in now removedresource_handlers.go
and then it was added as indirect dependancy.DataSource.ts
. I believe this is beneficial for us to understand where is what used, as some of these methods are part ofDataSourceAPI
and not called directly.async getLabels
method as it wasn't called anywhere.LegacyMetricFindQueryOptions
types and removesrangeRaw: options.rangeRaw,
as it is always undefined asrangeRaw
is not a part ofLegacyMetricFindQueryOptions
.ResetButton
andLabelSelector
components as they are not used anywheredashboard.json
for development. I tested it and it is a good dashboard.