Closed gwdawson closed 5 days ago
This looks good.
Can you please also update the readme.md? Can you also please add an example for provisioning? That way we can close this issue #370
In the readme can you please update this section as well? https://github.com/grafana/github-datasource?tab=readme-ov-file#access-token-permissions and also remove the first question from the faq? Thanks 🙏
@zoltanbedi as discussed in slack, i have removed all the duplicated documentation from the readme.
when implementing the app token auth, i forgot to add the required permissions to the documentation. this pr lists all required permissions when using github app auth
this pr also updates the provisioning section of the docs to include app auth examples.
Before (permissions): https://grafana.com/docs/plugins/grafana-github-datasource/latest/setup/token/#permissions
After (permissions):
Before (provisioning): https://grafana.com/docs/plugins/grafana-github-datasource/latest/setup/provisioning/
After (provisioning):
Fixes https://github.com/grafana/github-datasource/issues/370