search

grafana / grafana-ansible-collection

grafana.grafana Ansible collection provides modules and roles for managing various resources on Grafana Cloud and roles to manage and deploy Grafana Agent and Grafana
https://docs.ansible.com/ansible/latest/collections/grafana/grafana/index.html#plugins-in-grafana-grafana
GNU General Public License v3.0
128 stars 81 forks source link

Add check_mode: false to Mirmir and Promtail "Scrape GitHub" Task" #266

Closed x4e-jonas closed 2 weeks ago

x4e-jonas commented 2 weeks ago

The fix in https://github.com/grafana/grafana-ansible-collection/pull/262 missed Mimir and Promtail.

CLAassistant commented 2 weeks ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

voidquark commented 2 weeks ago

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This is missing: @x4e-jonas

x4e-jonas commented 2 weeks ago

This is missing: @x4e-jonas

Sounds a bit invasive. I'm not into US laws. Is this really required for such small changes? Feel free to takeover the patches as public domain.

voidquark commented 2 weeks ago

@x4e-jonas, since you chose not to sign the CLA, I have created a new PR: https://github.com/grafana/grafana-ansible-collection/pull/267. In this PR, I made additional code changes to support check mode for Promtail and also included Loki. I have tested check mode for both Loki and Promtail in this updated PR.

voidquark commented 2 weeks ago

Since https://github.com/grafana/grafana-ansible-collection/pull/267 has been merged, I believe the code needs to be adjusted. If other roles require check mode, they should be properly tested and implemented. As a result, Promtail and Loki can definitely be removed from this PR.

x4e-jonas commented 2 weeks ago

Thanks