search

grafana / grafana-app-sdk

An SDK for developing apps for grafana using kubernetes-like storage and operators
Apache License 2.0
44 stars 8 forks source link

Update resource.Schema to include ZeroList() #280

Closed IfSentient closed 3 months ago

IfSentient commented 3 months ago

Updated resource.Schema to include a ZeroList() function, and resource.NewSimpleSchema to require an example zero list object.

This is a follow-up to https://github.com/grafana/grafana-app-sdk/pull/277

radiohead commented 3 months ago

@IfSentient is this still in draft or is it ready for review?

IfSentient commented 3 months ago

@IfSentient is this still in draft or is it ready for review?

@radiohead I've marked it as draft because I'll change the target branch to main after https://github.com/grafana/grafana-app-sdk/pull/277 is merged, as it depends on that PR. Technically, nothing in it should change review-wise, but I think if I change the target it undoes approvals, so I didn't want to have folks have to re-review.