search

grafana / grafana-aws-sdk-react

Apache License 2.0
3 stars 1 forks source link

Add ConfigEditor util components #4

Closed andresmgot closed 2 years ago

andresmgot commented 3 years ago

Ref: #28

In #28 I suggest to create a generic ConfigEditor component to use in the different data sources. After a first revision, I don't think that's the best path forward, it forces to create some strict structure of the configuration that may be difficult to update and understand.

Rather than exposing a ConfigEditor, I have created two wrapper components around the ResourceSelector and the Input components to adapt them to the ConfigEditor requirements.

andresmgot commented 2 years ago

Thanks @sunker @sarahzinger! For reference, I have pushed some drafts for you to take a look to more complex examples (apart from the tests):

ConfigEditor

ConfigEditor