grafana / grafana-aws-sdk-react

Apache License 2.0
3 stars 1 forks source link

Chore: Move PublishConfig properties #41

Closed jackw closed 1 year ago

jackw commented 1 year ago

I noticed you're making use of publishConfig to set package.json properties which is only supported by yarn berry and pnpm.

Given the package.json always points at dist there's no need to migrate to either of these package managers and we can move the properties out to allow consuming projects to make use of the esm builds.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

jackw commented 1 year ago

Thanks for the reviews. I'm afraid I'm not familiar with this repo and cannot find any instructions on how versioning and publishing is handled. Could someone more familiar take over this PR to get the changes released please? 🙂

sarahzinger commented 1 year ago

@jackw no problem, will release a new version today, thanks for the contribution!