Closed bohandley closed 1 year ago
Looks good with the grafana/aws-sdk part, but I see this in e.g. Athena:
with the rest of the form with the old width.
Most of our datasources have some kind of datasource-specific config fields, so I guess the datasources would have to all be updated at some point?
@idastambuk, for the Athena issue, this is a good point!
Most of our datasources have some kind of datasource-specific config fields, so I guess the datasources would have to all be updated at some point?
As mentioned above, Prometheus only uses the SigV4ConnectionConfig but I am not sure where the Athena details are defined or what component those details are in. Is the Athena component another wrapper for the connection config used in other data sources?
@idastambuk, for the Athena issue, this is a good point!
Most of our datasources have some kind of datasource-specific config fields, so I guess the datasources would have to all be updated at some point?
As mentioned above, Prometheus only uses the SigV4ConnectionConfig but I am not sure where the Athena details are defined or what component those details are in. Is the Athena component another wrapper for the connection config used in other data sources?
Sorry @bohandley, I should probably have used a better example than Athena! We only currently have sigv4 option in OpenSearch, and at some point this flow will be used for that too I assume. I guess we will just have to adjust the width when we start updating our forms with the new auth, so disregard this!
Just to answer your question about config forms in Athena (and all other datasources I guess):
Exactly, we have the
What is this? This is a small UI change, an update to the input widths for the connection config component, only when it is inside the experimental auth component.
Why is this needed? The experimental auth component is part of the Config Overhaul project and the Prometheus config has recently been updated to use the new auth component.
Here is what it looks like without the update:
Here is what it looks like with the update:
Notes for the reviewers: Let me know if you have any questions or have any suggestions!