search

grafana / grafana-aws-sdk-react

Apache License 2.0
3 stars 1 forks source link

Set awsAssumeRoleEnabled to true if not defined in the config #57

Closed idastambuk closed 1 year ago

idastambuk commented 1 year ago

I committed a line in a refactor that was actually a change in logic: https://github.com/grafana/grafana-aws-sdk-react/pull/50/files#diff-9bd5c403af851469a03ce8274d95b0f68667afc08c9b8c4a595e1d11092ba111L45 In the Cloudwatch test, since we didn't use to define the awsAssumeRoleEnabled field, it defaulted to true. But now after the refactor it defaults to false. This might hide the field from some customers that didn't have it enabled before, hence this change.

idastambuk commented 1 year ago

Good thinking, @fridgepoet and @sarahzinger, added a lil test 😌