grafana / grafana-aws-sdk-react

Apache License 2.0
3 stars 1 forks source link

Minor refactor of ConfigSelect #6

Closed andresmgot closed 2 years ago

andresmgot commented 2 years ago

follow up of #4

Re-reading this I was not very happy with the jsonDataPath parameter that I added to the ConfigSelect component. I did it to avoid having to define the onChange function for each data source config but we are losing the strict typing (you could use a jsonDataPath that didn't exist). So I am removing it here.

[EDIT]

I also modified the InlineInput component with the same logic