search

grafana / grafana-aws-sdk-react

Apache License 2.0
3 stars 1 forks source link

Avoid running queries when mouse focus is changed #60

Open Amit-Hora opened 1 year ago

Amit-Hora commented 1 year ago

HI Team, This npm package is being used by trino/grafana plugin . The problem is if I am writing the Query in QueryEditor and if I click on something else , focus changes like move to next tab or click on any corner of screen the query gets executed

https://github.com/trinodb/grafana-trino/issues/248

I am not getting much help on what might be causing this issue all I see is there are calls made every time focus is changed in brower console and the calls are triggered by query -- http://localhost:3000/api/ds/query

Would appreciate any help and pointers

idastambuk commented 1 year ago

Hi @Amit-Hora thanks for submitting this! I suspect this has to do with your query running onBlur (triggered here) Since this particular component is using CodeEditor from grafana/ui, I'd suggest you instead extend the ui's CodeEditor and adjust it to not call onRunQuery() when onBlur triggers.

We have tried to move away from the pattern of running queries unless the user explicitly runs acts on it, so I'll bring it to the team that we remove that particular line. In the meantime I hope the above suggestion will work for you!