grafana / grafana-aws-sdk-react

Apache License 2.0
3 stars 1 forks source link

268 migrate aws sdk react components to the new form styling #62

Closed idastambuk closed 1 year ago

idastambuk commented 1 year ago

This is a part of migration to the new saga design system, namely using components from grafana/ui or the experimental components from /experimental. There are two parts to this, migrating query editor components and migrating config editor components, let me know if you'd rather have them split into two. Resource Selector cannot be split in the way I chose to do it, so I'm submitting a PR for both.

Thank you @aangelisc for all the support on this one!

Config Editor migration:

Before & After (in Redshift Config editor) Screenshot 2023-10-02 at 10 45 10 PM Screenshot 2023-10-02 at 10 44 52 PM

ezgif-1-72f00732bb

What was done:

Connection Config:

Query Editor components (ResourceSelector, FillValueSelect, FormatSelect)

This is what the query editor looks like in Redshift now. The changes from this PR are only with regards to the fields, not the layout. The layout changes are Redshift-specific.

Screenshot 2023-10-03 at 12 26 48 PM
aangelisc commented 1 year ago

Phenomenal work @idastambuk! Well done for getting everything in, I think it looks like a massive improvement 😊