search

grafana / grafana-aws-sdk-react

Apache License 2.0
3 stars 1 forks source link

SQL util functions #7

Closed andresmgot closed 2 years ago

andresmgot commented 2 years ago

Ref: https://github.com/grafana/grafana-aws-sdk/issues/28

This PR includes some more functions shared between SQL datasources (used in Suggestions and the Datasource class).

andresmgot commented 2 years ago

But for now, can we rename that function or the util file in some way so that it becomes obvious that this is only applicable for SQL plugins?

I am okay changing the name of the function but this is nicely covered by typescript. The function filterQuery is expecting a SQLQuery as an argument (this is a query with the value rawSQL) so this could not be used by X-ray. In any case, I am fine making the function names explicit.