grafana / grafana-aws-sdk-react

Apache License 2.0
3 stars 1 forks source link

Fix ESM build path #78

Closed jackw closed 7 months ago

jackw commented 8 months ago

This PR fixes the mentioned issue regarding mismatched "module" path and esm dist path.

It also:

Fixes: #73

Notes for reviewers:

I have not tested this against any plugin builds nor have I tested it against a build of Grafana core yet.

sarahzinger commented 8 months ago

hmmm. just a heads up that I just realized I get errors like this in the console when I use this with athena... but I confirmed I see the same thing when I install the main version of this sdk, so I believe unrelated to this pr. Just sharing in case it comes up for others while reviewing. Would be something good to sort out before we publish a new version though (although wouldn't be surprised if the fix is in athena and not in this package).

Screenshot 2024-03-05 at 9 45 51 AM