grafana / grafana-iot-twinmaker-app

AWS IoT TwinMaker Application Plugin for Grafana
Apache License 2.0
19 stars 12 forks source link

Config editor: Fix workspace loading in new form styling and prepare 1.10.0 #258

Closed idastambuk closed 9 months ago

idastambuk commented 9 months ago

What this PR does / why we need it:

In the old form styling, the Workspaces Select input was set to be disabled if there were no workspaces. This doesn't seem to do anything, since the default state is [] but the user is still able to click on it. This is ok, since the fetchWorkspaces function is only called on opening the dropdown. However, in the new form styling the disabled attribute is applied, so the user is unable to fetch workspaces for a new Twinmaker datasource. Probably should have caught this earlier, but better late than never I guess 😔

I removed the disabled attribute, since the flow works perfectly fine without it (i.e. the same as in the old form styling).

ezgif-2-1bfa1cad82

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: