search

grafana / grafana-iot-twinmaker-app

AWS IoT TwinMaker Application Plugin for Grafana
Apache License 2.0
19 stars 12 forks source link

Extra empty blue banner is showing for SceneViewer with matterport scene #274

Closed sheilaXu closed 3 weeks ago

sheilaXu commented 6 months ago

What happened: When loading a matterport scene in Grafana v10, there will be an extra empty blue banner showing up that is not interact-able. The same scene will not have the blue banner when using Grafana v9, and non-matterport scene is not having the blue banner in v10

Screenshot 2024-02-15 at 5 31 31 PM

What you expected to happen: There should be no blue banner.

How to reproduce it (as minimally and precisely as possible): With Grafana v10, load a matterport scene in SceneViewer panel

Anything else we need to know?: From console log, there is a failed matterport API call. But since the scene is loading fine, if it's causing the blue banner, then we want to remove it for this case.

Environment:

sarahzinger commented 6 months ago

Reaching out to the TwinMaker team at AWS to see their thoughts on this

torkelo commented 6 months ago

@sheilaXu is this on Grafana Cloud? Looks like the cloud trial / licence banner

What is SceneViewer?

sarahzinger commented 6 months ago

SceneViewer is a panel visualization that comes installed with the twinmaker datasource/app.

sarahzinger commented 6 months ago

I'm a bit stumped but my current hunch is that there is some kind of global style change in grafana that is causing unexpected style changes in Twinmaker's Scene Viewer Panel.

The Blue Bar itself is coming from within the matterport-viewer webcomponent which I don't believe grafana has any direct control over: Image

What's interesting is that this "error-bar" component exists in the dom in earlier versions of grafana as well it's just getting covered by the panel title or something? Image

Is it possible for the Twin Maker team to edit the css in the Matterport Web component?

mitchlee-amzn commented 6 months ago

This blue bar is coming from Matterport, the likely fix is to upgrade the Matterport SDK Version, update the IotAppKit version in the Grafana Plugin, and see. Otherwise, I can reach out to our contacts at Matterport to get some next steps.

taleena commented 1 month ago

Update that TM team may have a fix in for this and is awaiting testing feedback from customer, then we can close this out.

taleena commented 3 weeks ago

TM team mentioned we can close this out, customer verified. Thank you!