OATs build fixes, better HTTP error test

grafana / grafana-opentelemetry-dotnet

Grafana's distribution of OpenTelemetry instrumentation for .NET

Apache License 2.0

37 stars 6 forks source link

OATs build fixes, better HTTP error test #79

Closed matt-hensley closed 9 months ago

matt-hensley commented 9 months ago

Changes

Updates build for .NET 8 SDK Improves HTTP GET error controller action to return a 500, and adds OATs test looking for HTTP error span.

Merge requirement checklist

[x] Unit tests added/updated
[ ] CHANGELOG.md file updated for non-trivial changes
[ ] Changes in public API reviewed (if applicable)

matt-hensley commented 9 months ago

Thanks for adding this. I added a few comments, related to the fact that tests aren't consistently defined with new HTTP semantic conventions.

However, even with those changes, I don't get the new error-test to pass.

The Ginkgo --focus parameter was skipping some tests due to how testcase names were being generated. This PR improves name generation.

Running Ginkgo from the OATs yaml directory should show the HTTP tests now working, even without the PR to improve focus filtering.