grafana / grafana-operator

An operator for Grafana that installs and manages Grafana instances, Dashboards and Datasources through Kubernetes/OpenShift CRs
https://grafana.github.io/grafana-operator/
Apache License 2.0
889 stars 389 forks source link

Allow deployment labels to use "grafana-operator.labels" instead of just "grafana-operator-labels.selectorLabels" #1546

Closed David-John-Nintex closed 1 month ago

David-John-Nintex commented 4 months ago

Is your feature request related to a problem? Please describe. We have a set of labels that we need to apply to our cluster in order for our service to deploy (enforced by keda), and we would like to not have to disable these checks for this operator.

We have to keep a copy of your chart local and change the selectorLabels to labels to get the deployment to pass.

(If applicable)If your feature request solves a bug please provide a link to the community issue No

Describe the solution you'd like We would love a way to allow the user to select which set of labels to use for the deployment template, or alternatively use the labels as the default for the Pod

Describe alternatives you've considered We are currently copying your template into our own private repo so we can update the labels field.

Additional context We know our requirements are not to everyone's like, which is why I'm suggesting having a switch to allow one set of values or the other

Existing solutions Not so much an existing solution, but something that's easy to implement

Proposed change

1560

theSuess commented 4 months ago

Thanks for the report!

Please create a PR with your recommended change - that way it's easier to discuss

David-John-Nintex commented 4 months ago

Thanks for the report!

Please create a PR with your recommended change - that way it's easier to discuss

I have opened a new PR with my change