search

grafana / grafana-plugin-examples

189 stars 53 forks source link

Logs data source: deprecate showContextToggle #215

Closed matyax closed 9 months ago

matyax commented 1 year ago

Part of https://github.com/grafana/grafana/pull/77232, where we're deprecating the showContextToggle function.

Which issue(s) this PR fixes:

Related to https://github.com/grafana/grafana/issues/66819

ivanahuckova commented 1 year ago

I guess, we can just leave this open until 10.3 with deprecated showContext is released.

academo commented 9 months ago

@matyax can you remove this code without modifying the underlying grafana version of the example or waiting for the new release?

matyax commented 9 months ago

Hey @academo ! I'm not really sure what you mean. Is it about upgrading @grafana/data? Because I did it to get updated types from that package.

academo commented 9 months ago

Hey @academo ! I'm not really sure what you mean. Is it about upgrading @grafana/data? Because I did it to get updated types from that package.

Yes indeed. If you need it upgraded then It is ok. We like to keep all the examples synced with the same versions so we can reliable know what's happening to them.

matyax commented 9 months ago

Yes, it's required, and I've been waiting for the 10.3 release for this. Thanks for checking!