search

grafana / grafana-plugin-examples

189 stars 53 forks source link

Examples: App with RBAC #242

Closed gamab closed 7 months ago

gamab commented 9 months ago

Thanks @alexanderzobnin! I think I'm going to add access-control on the backend as well.

alexanderzobnin commented 9 months ago

Ah, ok, backend just not covered yet.

andresmgot commented 8 months ago

adding @josmperez to review the documentation

sunker commented 8 months ago

Nice @gamab. 👍 Our new e2e testing package supports testing RBAC. If you want to, you can take a stab at adding some tests. If not, I'll try to do it later.

gamab commented 7 months ago

@sunker as you want, if you can write them I'd be glad or we could maybe pair, because I'm a bit unsure of what and how to test :smile:

josmperez commented 7 months ago

Great, detailed README.md file! I've edited it, mostly for conformity to Grafana style guidelines. Please take a look and ensure that no inaccurates have been introduced.

gamab commented 7 months ago

Alright I merged the plugin example but if you have any remark let's iterate on it :slightly_smiling_face:

The failing github action has nothing to do with this PR :grin:

Thanks a lot for reviewing this :100: