grafana / grafana-plugin-examples

189 stars 53 forks source link

Add example of an app with a WebAssembly dependency #246

Closed sd2k closed 2 months ago

sd2k commented 9 months ago

Using WebAssembly in a plugin requires changing some webpack config. This adds an example of how to do so.

I've mainly made this as a reproducible example to demonstrate a bug in Grafana 10.2-10.4.0, but perhaps it's useful to have around as an e2e test.

Not sure how useful it really is but it was lying around as a draft, happy to close if you don't think it's needed!

andresmgot commented 7 months ago

Adding @josmperez and @sympatheticmoose as a reviewers here to evaluate if we want this example. Sounds to me that it could be better documentation in the developer page.

academo commented 7 months ago

if we decide to move on with this example we should make sure the integration tests are testing the real cases for this plugins.

We run these integrations tests daily to make sure the examples work and that the existing and upcoming changes in the grafana packages won't break plugins.

josmperez commented 7 months ago

Adding @josmperez and @sympatheticmoose as a reviewers here to evaluate if we want this example. Sounds to me that it could be better documentation in the developer page.

In a recent conversation with David, he and I both expressed a desire in Q2 to better sync up and integrate our documentation, examples, and tutorials. Let's do some improvements/evaluation of this example in the near future.

sd2k commented 2 months ago

Closing because I don't think this is needed any more, the custom webpack stuff has been upstreamed into create-plugin's webpack config.