search

grafana / grafana-plugin-examples

189 stars 53 forks source link

Basic App: use the new `PluginPage` component in a backwards compatible way. #98

Closed leventebalogh closed 2 years ago

leventebalogh commented 2 years ago

This PR is an experiment. It is mostly based on the logic introduced in https://github.com/grafana/grafana-starter-app/pull/39.

What changed?

We have introduced a new PluginPage component in https://github.com/grafana/grafana/pull/53174, however unfortunately it's not straightforward to make it work in older versions of Grafana (<9.2). My intention was to try to give a "oneliner" solution for plugin developers to benefit from the new functionality while still being compatible with older versions of Grafana, and for this I shifted the migration-related logic into a separate package which we would own (experiment).

Checkt the experimental package @grafana/migrations →

New Top Navigation Fallback (older versions)
Screenshot 2022-09-29 at 12 09 25 Screenshot 2022-09-29 at 12 10 55
leventebalogh commented 2 years ago

We have decided (Plugins Platform daily, 2022-10-03) that we won't integrate this feature into our plugin examples until the top-nav is enabled even without a feature flag.