search

grafana / grafana-zabbix

Zabbix plugin for Grafana dashboard
http://play.grafana-zabbix.org
Apache License 2.0
2.06k stars 458 forks source link

"Direct DB connection" config isn't stay enabled on 3.10.2 #731

Closed fernandolcx closed 5 years ago

fernandolcx commented 5 years ago

Describe the bug The datasource validates and saves successfully, but when refreshing the page the "Enable" switch from Direct DB connection appears turned off.

Screenshots image

saved. Then F5:

image

Software versions

Grafana Zabbix Grafana-Zabbix Plugin
6.1.4 4.2.1 3.10.2
and111016 commented 5 years ago

Confirm same issue Grafana - Grafana v5.4.2 (d812109) Zabbix - 3.4.15 Grafana-Zabbix Plugin - 3.10.1, 3.10.2

On 3.10.0 work

kaeltis commented 5 years ago

Can confirm the same with MySQL

Grafana - v6.1.6 (cf9cb45) Zabbix - 4.2.1. Grafana-Zabbix Plugin - 3.10.2

DrKomtur commented 5 years ago

same for PSQL Grafana - v6.0.2 Zabbix - 4.0.7 Plugin - 3.10.2

anthonysomerset commented 5 years ago

same for InfluxDB FYI

silvermoon-h commented 5 years ago

Yes, some issue. Grafana - v6.1.6 Zabbix - 4.2.1 grafana-zabbix - 3.10.2

Positronico commented 5 years ago

Same here. Noticed when trying to add the same DB connection on a second Org. The first one (create a while ago) is still working.

Grafana - v6.1.6 Zabbix - 4.2.1 grafana-zabbix - 3.10.2

anthonysomerset commented 5 years ago

so i have a temp workaround that seems to work

manually edit the row in the data_source table and edit the json_data column

NOTE: the zabbix api user/pass is in this field so only amend the dbConnectionDatasourceName and dbConnectionRetentionPolicy fields as required

example (mysql/PGSQL):

{"addThresholds":false,"alerting":false,"alertingMinSeverity":3,"dbConnectionDatasourceId":null,"dbConnectionEnable":true, "dbConnectionDatasourceName":"Zabbix-PostgreSQLTSDB", "dbConnectionRetentionPolicy":"","disableReadOnlyUsersAck":true,"keepCookies":[],"oauthPassThru":false,"password":"xxxxxxxxx","trends":true,"trendsFrom":"7d","trendsRange":"4d","username":"xxxxxxxxx","zabbixVersion":4}

InfluxDB:

{"addThresholds":false,"alerting":false,"alertingMinSeverity":3,"dbConnectionDatasourceId":null,"dbConnectionEnable":true, "dbConnectionDatasourceName":"Zabbix-InfluxDB", "dbConnectionRetentionPolicy":"SomeRetentionPolicy","disableReadOnlyUsersAck":true,"keepCookies":[],"oauthPassThru":false,"password":"xxxxxxxxx","trends":true,"trendsFrom":"7d","trendsRange":"4d","username":"xxxxxxxxx","zabbixVersion":4}

Then you can view the data source in the GUI to verify the change worked just don't save it again via the GUI

tiago-cruz-movile commented 5 years ago

Same thing here, env:

babarbobar commented 5 years ago

Same while testing with InfluxDB (with Effluence): Zabbix 4.0 Grafana 5.4.2 Plugin 3.10.2

tolsadus commented 5 years ago

What the feature broken, or just the UI? Thanks for the quick fix! 👍