Closed tktr closed 5 years ago
Hard to have options for every possible scenario and use case.
Closing this for now but we other can upvote this and we can reopen if there is a large demand for this.
This breaking change is indeed quite annoying. For a 24/7 view, you often need the visual context that the variables provide. Wouldn't it be a valid option to add a setting parameter, while creating the variable, if it should be displayed in tv and/or kiosk mode? In my opinion, this could be a very flexible solution, which should cover, in combination of the tv and kiosk mode, most of the possible scenarios.
The FR #7691, which seems to me to be the initial request for this change, was for a specific scenario, for which a workaround already exists
I know that we can set the variable values through the URL but having it in the GUI is more user friendly.
In my opinion this not a valid argument to introduce a breaking change. An while reading your own comments, I guess you had the same feeling:
so new breaking change of kiosk mode (to hide submenu (ie variables)), would implement this FR #7691 I don't like introducing a breaking change, really hard to judge the impact this breaking change will have.
However I also understand that you don't want to reopen the same topic over and over again.
I also would like to see the submenu visible in kiosk node, not only for the template variables, but also for Dashboard Links which 'users' can use to navigate between different dashboards.
Currently for this reason, I am unable to use kiosk node which is a shame as it's a nice feature...
For all who are affected by this, I found/made a workaround to keep things functional.
/d/<dashboard_giberisch>/${__cell_0}?var-foo=${__cell_0}&kiosk=tv
This might not work for your data-source and multiple-selections.
We release dashboards to customers in kiosk mode - but now there is no way to have them select from a pull down menu that we used to expose via variables. Thus the user cannot choose different options which would refresh various charts.
Any update on this? This seems like the most common use case you just randomly chose to destroy
We also would like to embed Grafana inside another app using an iframe. Inside the iframe we would like variables and time controls, but nothing else. No ability to edit, switch dashboards, change view mode, etc. Thank you!
In my opinion @torkelo https://github.com/grafana/grafana/issues/7691 was the breaking change and removed functionality that existed previously. It looks like others have the same opinion too
Open for a PR that adds more control over this
We're embedding some dashboards/widgets in kiosk mode as iframe into other sites and therefore it would be great to have the option to use editable variables :)
it's too bad that can not have variables in tv mode, maybe we can make this an option in preferences
grafana just hide the template variables in the web page. I found a solution for this issue
.view-mode--tv .submenu-controls{display: flex}
to the end of the two css filesthen you'll get template variables shown in tv mode
2. .view-mode--tv
+1,
also works for kiosk mode:
.view-mode--kiosk .submenu-controls{display: flex !important}
or
.view-mode--kiosk .navbar, .view-mode--kiosk .sidemenu, .view-mode--kiosk .submenu-controls, .view-mode--tv .submenu-controls{display: flex !important}
it's too bad that can not have variables in tv mode, maybe we can make this an option in preferences
grafana just hide the template variables in the web page. I found a solution for this issue
- find the grafana.dark/light.xxxxxxxxxxxxxxxx.css
- append
.view-mode--tv .submenu-controls{display: flex}
to the end of the two css filesthen you'll get template variables shown in tv mode
thanks a lot, I find a way to resolve this trouble for a long time, now I can have a good time.
it's too bad that can not have variables in tv mode, maybe we can make this an option in preferences
grafana just hide the template variables in the web page. I found a solution for this issue
- find the grafana.dark/light.xxxxxxxxxxxxxxxx.css
- append
.view-mode--tv .submenu-controls{display: flex}
to the end of the two css filesthen you'll get template variables shown in tv mode
希望国内的小伙伴能看到这个解决方案,这个以及楼下的回复都是解决如何在grafana的kiosk模式下自定义隐藏或显示global variable、其他组件的方法。希望百度能爬到这条信息方便国内小伙伴解决烦恼。
share my kiosk config which append to the end of the two css files as what xuhrc said above: .view-mode--kiosk .submenu-controls,.view-mode--kiosk .navbar{display:flex !important} .view-mode--kiosk .navbar-buttons--tv,.view-mode--kiosk .sidemenu,.view-mode--kiosk .navbar-page-btn{display:none !important} .view-mode--kiosk .navbar:before {content:"陕重汽-信息技术部Zabbix监控";font-size:3vw;margin:auto;}
I found a solution for this issue
- find the grafana.dark/light.xxxxxxxxxxxxxxxx.css
- append
.view-mode--tv .submenu-controls{display: flex}
to the end of the two css files
This is a great mod, thanks for posting! i am making use of this, but for showing VARs dropdown while in KIOSK mode. It should be noted that making this change could (will?) very likely be overwritten by a future update, so it may disappear (and have to be re-modified by end user, post grafana update)
also works for kiosk mode: .view-mode--kiosk .submenu-controls{display: flex !important}
(would be GREAT to have this feature built into grafana, for the update issue referenced above). thanks, LOVE GRAFANA!
Hi all, thanks for all the information.
also works for kiosk mode: .view-mode--kiosk .submenu-controls{display: flex !important}
But I also want to show the time range settings in the kisok mode. Would be great if somebody know what I have to change in the .css file.
Thanks!
With Grafana 8.0.3 this solution of adding the code at the and of the dark/light css doesn't seem to work anymore. Please Grafana team, add this feature. In the meantime what could be the workaround? Thanks
Would also like this. Same use case, embedded grafana dashboard in iframe, in which users should not be able to navigate around grafana, but they should be able to change the template variables on the dashboard they are viewing.
Turning off kiosk mode is not a solution because it suddenly looks like you are viewing the entirety of grafana and not one dashboard
The suggested workaround here is not an option for me either, since we run the grafana docker image and can't change the source code.
Could you please post an example on what you're getting? at the end what I need is to eliminate the left bar bust still having dashboard links and variables dropdown
That is basically what I need as well.
I don't really have anything to show you. I just have a normal non-kiosk grafana dashboard with a sidebar and variables, embedded in an
One sort of(but not really) workaround is to set "marginLeft: -60px" on the iframe containing the dashboard, and turning off kiosk mode.
That way the left sidebar will be hidden off screen, and it looks very similar to kiosk mode, just with template variables.
But this is not a viable workaround either, since when opening the page on mobile, the sidebar will not be there. There will be a button to open the menu at the top instead. So then the "-60px" will be way off and it looks wrong on mobile/other smaller screens.
With Grafana 8.0.3 this solution of adding the code at the and of the dark/light css doesn't seem to work anymore. Please Grafana team, add this feature. In the meantime what could be the workaround? Thanks
+1
With Grafana 8.0.3 this solution of adding the code at the and of the dark/light css doesn't seem to work anymore. Please Grafana team, add this feature. In the meantime what could be the workaround?
Same problem.
With Grafana 8.0.3 this solution of adding the code at the and of the dark/light css doesn't seem to work anymore. Please Grafana team, add this feature. In the meantime what could be the workaround?
issue solved by below queryparameter. kiosk=full
no, you don't solve the problem. WE already know that is possible add this on the url. This is the problem, you can just cancel it and be back. We need a way to set a kiosk mode without possibility to go out by the viewer But maybe I'm misunderstanding you. Where do you put it?
We would like to see this implemented as well.
We're using grafana in Microsoft Teams tab. The kiosk mode is perfect. But right now, we have to create one tab for each combination of parameters (set through the URL).
Ideally, an additional kiosk mode like tv-template
would be perfect.
Add me to this as well...
On Fri, Sep 17, 2021 at 10:14 AM Pierre PACI @.***> wrote:
We would like to see this implemented as well.
We're using grafana in Microsoft Teams tab. The kiosk mode is perfect. But right now, we have to create one tab for each combination of parameters (set through the URL).
Ideally, an additional kiosk mode like tv-template would be perfect.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_grafana_grafana_issues_15546-23issuecomment-2D921877229&d=DwMCaQ&c=udBTRvFvXC5Dhqg7UHpJlPps3mZ3LRxpb6__0PomBTQ&r=PRAnxyMrkyqShYhK1j8weMsZx29ez5Hn9F0s_svlRnQ&m=EWQKpBiy10kLLqlOiQ_pjuxtiYWYvRRMLBfFkUGGkVs&s=cpLuxMEVrdpLDXW0tAtMIIyO9RVVfoIWYkopXn5Zu8M&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AG3COWGOGS33YOZV5ORPXMLUCNLNPANCNFSM4GYTEDEA&d=DwMCaQ&c=udBTRvFvXC5Dhqg7UHpJlPps3mZ3LRxpb6__0PomBTQ&r=PRAnxyMrkyqShYhK1j8weMsZx29ez5Hn9F0s_svlRnQ&m=EWQKpBiy10kLLqlOiQ_pjuxtiYWYvRRMLBfFkUGGkVs&s=Db-f4VLWanjmaIgXcei302QQLJU06-jj60NroW5Fjws&e= . Triage notifications on the go with GitHub Mobile for iOS https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=udBTRvFvXC5Dhqg7UHpJlPps3mZ3LRxpb6__0PomBTQ&r=PRAnxyMrkyqShYhK1j8weMsZx29ez5Hn9F0s_svlRnQ&m=EWQKpBiy10kLLqlOiQ_pjuxtiYWYvRRMLBfFkUGGkVs&s=Nv4ESwJAyP2Q026fT7sUqp8-lRrl2l3wVoIqjTbAFxU&e= or Android https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=udBTRvFvXC5Dhqg7UHpJlPps3mZ3LRxpb6__0PomBTQ&r=PRAnxyMrkyqShYhK1j8weMsZx29ez5Hn9F0s_svlRnQ&m=EWQKpBiy10kLLqlOiQ_pjuxtiYWYvRRMLBfFkUGGkVs&s=UnfJPj8HIVlDDw7THMZVjTPBcrXpyqudqCYEutjB_qs&e=.
I found a solution for this issue.(It's not elegant, but it solves our scenario)
/public/app/features/dashboard/containers/DashboardPage.tsx showSubMenu -> true
<div className={styles.dashboardContent}> {initError && <DashboardFailed />} {showSubMenu && ( <section aria-label={selectors.pages.Dashboard.SubMenu.submenu}> <SubMenu dashboard={dashboard} annotations={dashboard.annotations.list} links={dashboard.links} /> </section> )} <DashboardGrid dashboard={dashboard} viewPanel={viewPanel} editPanel={editPanel} /> </div>
change into
<div className={styles.dashboardContent}>
{initError && <DashboardFailed />}
{true && (
<section aria-label={selectors.pages.Dashboard.SubMenu.submenu}>
<SubMenu dashboard={dashboard} annotations={dashboard.annotations.list} links={dashboard.links} />
</section>
)}
<DashboardGrid dashboard={dashboard} viewPanel={viewPanel} editPanel={editPanel} />
</div>
Any Chance you could mention which file this is done on? or where to do this edit?
On Wed, Apr 20, 2022 at 7:41 AM yang kewei @.***> wrote:
I found a solution for this issue.(It's not elegant, but it solves our scenario) `
{initError && } {showSubMenu && (
)}
<DashboardGrid dashboard={dashboard} viewPanel={viewPanel} editPanel={editPanel} /> </div>
change into
{initError && } {true && (
)}
<DashboardGrid dashboard={dashboard} viewPanel={viewPanel} editPanel={editPanel} /> </div>
`
— Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_grafana_grafana_issues_15546-23issuecomment-2D1103886212&d=DwMCaQ&c=udBTRvFvXC5Dhqg7UHpJlPps3mZ3LRxpb6__0PomBTQ&r=PRAnxyMrkyqShYhK1j8weMsZx29ez5Hn9F0s_svlRnQ&m=7YtAEN3tOtB5TdGjSK_nO54JGDM8ugddCW45M6XWAWj3eVg-P3Id40e8xN73B0Cm&s=1SwAEji8NxO0_MvDTk-xqDhrC2mpspGNo5k441KTHDc&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AG3COWHKX6QG6U3SWTOJQ2DVF73PFANCNFSM4GYTEDEA&d=DwMCaQ&c=udBTRvFvXC5Dhqg7UHpJlPps3mZ3LRxpb6__0PomBTQ&r=PRAnxyMrkyqShYhK1j8weMsZx29ez5Hn9F0s_svlRnQ&m=7YtAEN3tOtB5TdGjSK_nO54JGDM8ugddCW45M6XWAWj3eVg-P3Id40e8xN73B0Cm&s=riknByaBxrxM7qek2-3Si7TdFhaafOw6s8aM-ynDD_s&e= . You are receiving this because you commented.Message ID: @.***>
@meyerder sorry i didn't notice. i have modified
kiosk=full
stopped working after updating to 8.5.0
+1
Could you please implement this? It is a simple thing yet so many people would love this!
+1 i too am still looking for this feature: Namely - i have some users i share a kiosk URL with + ability to give the anonymous visitor Variable drop-down menu access (but NO sidebar).
Im aware this is not secure, and the user can still get to the sidebar links, however our grafana sites are internal access only and users access via a VPN.
(we need this feature to make the UI the "most simple", ie: we have users get confused by the sidebar. However kiosk mode + variables drop-down only, is such a clean, simple UI).
@cugykw his modification (3x replies up from here) does not seem to work any-longer (after grafana v9) , ie the modification of:
file: /public/app/features/dashboard/containers/DashboardPage.tsx
change: showSubMenu -> true
does not seem to work on v9 any more. (ie var menu does not appear in kiosk mode) - (so you may want to stick to pre v9 grafana if you need this). I am looking into the v9 code to try to find another temp fix. (and will update here if i do)
@torkelo : Also now that we can alter the Interval via a variable (ie a dropdown ) , this allows even the time-picker to be removed (as currently is in kiosk mode) - thus all that is needed is kiosk mode + variable dropdown menus (and ALOT of easy, clean functionality is provided).
thanks, LOVE GRAFANA!
When the grafana updated,the css file also has been changed( In the most cases, only the web elements of the class name which have been changed have an effect on the kiosk mode ),so we must find the new class name and write them append to the css files. Share my kiosk config which append to the end of the two css files with grafana v7.5.16: .view-mode--kiosk .sidemenu,.view-mode--kiosk .css-1bpq4j8,.view-mode--kiosk .css-1cgkl47 .toolbar-button{display:none !important}.view-mode--kiosk .page-toolbar,.view-mode--kiosk .css-1cgkl47 .button-group .toolbar-button,.view-mode--kiosk .submenu-controls{display:flex !important}.view-mode--kiosk .page-toolbar:before {content:"信息技术部-Prometheus监控";font-size:2vw;margin:auto;}
here is the result:
below is the version compare:
hope that helps.
@bob454522 I believe the source code change suggested by @cugykw in https://github.com/grafana/grafana/issues/15546#issuecomment-1103886212 does still work for v9 (tried on v9.0.4 specifically).
So, could someone please summarize the correct change to do in grafana 9? I need thise two option: 1) kiosk mode that shows only variable, without time filter 2) kiosk mode that shows both, variable and time filter Thanks
@svet-b How did you get it to work on v9.0.4? I tried modifying the file as per the comment and restarted grafana-server service but it didn't work. Did you had to do an extra step? (i.e. running some script/build?)
@vinnyo yes you need to build from source. It mostly comes down to running the first few RUN
lines in the Dockerfile
Ah, Thanks for your input @svet-b
+1
We also would like to embed Grafana inside another app using an iframe. Inside the iframe we would like variables and time controls, but nothing else. No ability to edit, switch dashboards, change view mode, etc. Thank you!
+1
+1
+1
+1
+1
+1
+1
+1
+1
+1
Release
v5.3
introduced a breaking change making template variables invisible in Kiosk mode (#13025).In our setup, we're exposing dashboards through a third party application. In the past, kiosk mode came in handy for this purpose hiding navbars which are needless in this case. However, with the current releases > 5.3, those exposed dashboards are rendered unusable as users are no longer able to change the variables.
Apart from that, as it was already pointed out in #7691, it might be sometimes preferred to have a visual context of the graphs shown in the current view.
That being said, I can understand that the use cases for kiosk mode are diverse and it's difficult to cover them all. But wouldn't it make sense to have another option allowing to set the visibility of variables?