grafana / grafana

The open and composable observability and data visualization platform. Visualize metrics, logs, and traces from multiple sources like Prometheus, Loki, Elasticsearch, InfluxDB, Postgres and many more.

https://grafana.com

GNU Affero General Public License v3.0

64.93k stars 12.12k forks source link

Grafana/UI: IconButton has right margin #70348

Open aocenas opened 1 year ago

aocenas commented 1 year ago

What went wrong?

IconButton has a right margin: https://github.com/grafana/grafana/blob/24502c4c4a2ea95659115834d6937377c22993b3/packages/grafana-ui/src/components/IconButton/IconButton.tsx#L108

I don't think library elements should have margins as it is hard to predict in what layout context will they be used.

How do we reproduce it?

Step 1:

Open Grafana and do X

Step 2:

Now click button Y

Step 3:

Wait for the browser to crash. Error message says: "Error..."

What Grafana version are you using?

Grafana v10.1.0-pre (cc42242)

Optional Questions:

Is the bug inside a Dashboard Panel?

Copy the panel's "get-help" data here

Grafana Platform?

None

User's OS?

No response

User's Browser?

No response

Is this a Regression?

None

Are Datasources involved?

No response

Anything else to add?

No response

grafanabot commented 1 year ago

@aocenas please add one or more appropriate labels. Here are some tips:

if you are making an issue, TODO, or reminder for yourself or your team, please add one label that best describes the product or feature area. Please also add the issue to your project board. :rocket:
if you are making an issue for any other reason (docs typo, you found a bug, etc), please add at least one label that best describes the product or feature that you are discussing (e.g. area/alerting, datasource/loki, type/docs, type/bug, etc). Our issue triage doc also provides additional guidance on labeling. :rocket:

Thank you! :heart:

ashutosh-rath02 commented 1 year ago

Hey @aocenas, Can I work on this issue?

A beginner's question, can you tell me how do I add labels to my PR?

JoaoSilvaGrafana commented 1 year ago

Thanks for raising this! I have made a related comment in another issue. Once we have discussed this with the team we will get back to you if this is something we can do at the moment or not 🙏

aocenas commented 1 year ago

@Lucif3r-in thanks for the PR, let's wait for @JoaoSilvaGrafana to confirm this should be changed. It's a small change but can potentially break some layout elswhere that relies on this.