grafana / grafana

The open and composable observability and data visualization platform. Visualize metrics, logs, and traces from multiple sources like Prometheus, Loki, Elasticsearch, InfluxDB, Postgres and many more.
https://grafana.com
GNU Affero General Public License v3.0
65.19k stars 12.16k forks source link

Move cloudwatch's copied `instrumentContext` into grafana-plugin-sdk-go #82033

Open njvrzm opened 9 months ago

njvrzm commented 9 months ago

What is the chore?: In order to keep log output the same when decoupling cloudwatch from pkg/infra/log I copied the instrumentContext method from that package into cloudwatch.go. This should be in the sdk instead so it can be used by other datasources. It's not entirely clear to me where that leaves the existing instrumentContext and the associated ContextualLoggerMiddleware, so this needs some discussion.

grafanabot commented 9 months ago

@njvrzm please add one or more appropriate labels. Here are some tips: