search

grafana / grafana

The open and composable observability and data visualization platform. Visualize metrics, logs, and traces from multiple sources like Prometheus, Loki, Elasticsearch, InfluxDB, Postgres and many more.
https://grafana.com
GNU Affero General Public License v3.0
61.15k stars 11.68k forks source link

Prometheus: AzureCredentials from Azure React SDK #82344

Closed kostrse closed 4 weeks ago

kostrse commented 4 months ago

Use frontend AzureCredentials definitions from the @grafana/azure-sdk library to share common parts of the Azure authentication logic among multiple datasources.

github-actions[bot] commented 2 months ago

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

itsmylife commented 2 months ago

@bohandley are we gonna able use it? I am asking this with referring this PR

bohandley commented 2 months ago

@itsmylife we can use it (need to test it with an Azure instance), but this is only part of the azure code. There is more work that needs to be done. All the Azure auth files will need to be moved. This helps though.

This is the issue to move all of the files and the @grafana/partner-datasources team has responded that it is on their list but they are focusing on Azure Monitor/ADX first.

bohandley commented 2 months ago

Hi @kostrse! Thank you for your contribution. Can you run prettier and merge main into your branch?

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Sergey Kostrukov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

github-actions[bot] commented 1 month ago

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

github-actions[bot] commented 4 weeks ago

This pull request has been automatically closed because it has not had any further activity in the last 2 weeks. Thank you for your contributions!