search

grafana / grafana

The open and composable observability and data visualization platform. Visualize metrics, logs, and traces from multiple sources like Prometheus, Loki, Elasticsearch, InfluxDB, Postgres and many more.
https://grafana.com
GNU Affero General Public License v3.0
61.15k stars 11.68k forks source link

Imageupload: Add support for custom ACL on s3 objects #86442

Open Elvinos33 opened 2 months ago

Elvinos33 commented 2 months ago

What is this feature? Adds a setting in the config that lets you change the ACL of the images that are uploaded to Amazon S3 with a default of "public-read".

Why do we need this feature? Currently Grafana only allows images to have the ACL of "public-read" when uploaded to S3. This could become a security issue if the data the graph contains is sensitive.

Who is this feature for? Anyone who wants to protect sensitive information in their graphs by not exposing it to the public.

Which issue(s) does this PR fix?:

Fixes #86441

Special notes for your reviewer:

Please check that:

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 4 weeks ago

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

Elvinos33 commented 3 weeks ago

Could this get a review? I still think it should be added to Grafana, as it would be very helpful.