search

grafana / grafana

The open and composable observability and data visualization platform. Visualize metrics, logs, and traces from multiple sources like Prometheus, Loki, Elasticsearch, InfluxDB, Postgres and many more.
https://grafana.com
GNU Affero General Public License v3.0
60.72k stars 11.61k forks source link

Alerting: Update silences creation to support `__alert_rule_uid__` and move into drawer #87320

Closed tomratcliffe closed 1 day ago

tomratcliffe commented 2 weeks ago

What is this feature?

Moves alert rule silence creation into a drawer that pops out when selecting to create a silence from the list view.

Why do we need this feature?

We need the ability to create more targeted alert rule silences. The most sensible way to allow this is by tying a silence to an alert rule's UID.

This means it makes more sense to show the silence creation without taking a user away from the list view image image

Which issue(s) does this PR fix?:

Fixes #86981

konrad147 commented 3 days ago

/deploy-to-hg

ephemeral-instances-bot[bot] commented 3 days ago
ephemeral-instances-bot[bot] commented 3 days ago

Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs

Error message handling pull request comment event: running grafana-build deb: executing command: stdout= stderr=go: downloading dagger.io/dagger v0.11.0 go: downloading github.com/urfave/cli/v2 v2.27.1 go: downloading go.opentelemetry.io/otel v1.25.0 go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.25.0 go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.25.0 go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.25.0 go: downloading go.opentelemetry.io/otel/sdk v1.25.0 go: downloading go.opentelemetry.io/otel/trace v1.25.0 go: downloading golang.org/x/sync v0.6.0 go: downloading github.com/Khan/genqlient v0.6.0 go: downloading github.com/vektah/gqlparser/v2 v2.5.6 go: downloading github.com/go-logr/logr v1.4.1 go: downloading go.opentelemetry.io/otel/metric v1.25.0 go: downloading go.opentelemetry.io/proto/otlp v1.1.0 go: downloading google.golang.org/protobuf v1.33.0 go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240401170217-c3f982113cda go: downloading google.golang.org/grpc v1.63.0 go: downloading github.com/adrg/xdg v0.4.0 go: downloading github.com/mitchellh/go-homedir v1.1.0 go: downloading github.com/99designs/gqlgen v0.17.31 go: downloading golang.org/x/exp v0.0.0-20231110203233-9a3e6036ecaa go: downloading github.com/go-logr/stdr v1.2.2 go: downloading github.com/cenkalti/backoff/v4 v4.3.0 go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.2 go: downloading github.com/xrash/smetrics v0.0.0-20201216005158-039620a65673 go: downloading golang.org/x/sys v0.18.0 go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.19.0 go: downloading github.com/Masterminds/semver v1.5.0 go: downloading golang.org/x/net v0.23.0 go: downloading github.com/russross/blackfriday/v2 v2.1.0 go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20240227224415-6ceb2ff114de go: downloading golang.org/x/text v0.14.0 2024/05/14 11:10:25 OTEL_EXPORTER_OTLP_ENDPOINT not set. Disabling tracing. time=2024-05-14T11:10:31.517Z level=INFO msg="Initializing tar.gz artifact with options" name=grafana-pro "build ID"=12345 version=10.1.0 distro=linux/amd64/dynamic static=false enterprise=true 2024/05/14 11:10:31 if git -C src checkout alerting/silences-drawer; then echo "checked out alerting/silences-drawer"; else exit 3; fi 2024/05/14 11:13:11 if git -C src checkout main; then echo "checked out main"; else exit 3; fi time=2024-05-14T11:13:15.094Z level=INFO msg="Initializing backend artifact with options" static=false version=10.1.0 name=grafana-pro distro=linux/amd64/dynamic 2024/05/14 11:13:15 if git -C src checkout alerting/silences-drawer; then echo "checked out alerting/silences-drawer"; else exit 3; fi time=2024-05-14T11:13:15.116Z level=INFO msg="Adding artifact to dag..." filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.deb artifact=deb:pro:linux/amd64/dynamic time=2024-05-14T11:13:15.116Z level=INFO msg="getting dependencies..." artifact=deb:pro:linux/amd64/dynamic filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.deb service=ArtifactHandler time=2024-05-14T11:13:15.116Z level=INFO msg="got dependencies" artifact=deb:pro:linux/amd64/dynamic filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.deb service=ArtifactHandler count=1 time=2024-05-14T11:13:15.116Z level=INFO msg="getting dependencies..." artifact=deb:pro:linux/amd64/dynamic filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.tar.gz service=ArtifactHandler time=2024-05-14T11:13:15.117Z level=INFO msg="got dependencies" artifact=deb:pro:linux/amd64/dynamic filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.tar.gz service=ArtifactHandler count=5 time=2024-05-14T11:13:15.117Z level=INFO msg="getting dependencies..." artifact=deb:pro:linux/amd64/dynamic filename=bin/grafana-pro/linux/amd64/dynamic service=ArtifactHandler time=2024-05-14T11:13:15.117Z level=INFO msg="got dependencies" artifact=deb:pro:linux/amd64/dynamic filename=bin/grafana-pro/linux/amd64/dynamic service=ArtifactHandler count=0 time=2024-05-14T11:13:15.117Z level=INFO msg="getting builder..." artifact=deb:pro:linux/amd64/dynamic filename=bin/grafana-pro/linux/amd64/dynamic service=ArtifactHandler time=2024-05-14T11:13:15.117Z level=INFO msg="got builder" artifact=deb:pro:linux/amd64/dynamic filename=bin/grafana-pro/linux/amd64/dynamic service=ArtifactHandler time=2024-05-14T11:13:15.117Z level=INFO msg="building directory..." artifact=deb:pro:linux/amd64/dynamic filename=bin/grafana-pro/linux/amd64/dynamic service=ArtifactHandler 2024/05/14 11:13:15 Building with command 'if [ -d pkg/cmd/grafana ]; then go build -ldflags="-X \"main.version=10.1.0\" -X \"main.commit=$(cat ./.buildinfo.commit)\" -X \"main.buildBranch=$(cat ./.buildinfo.branch)\" -X \"main.enterpriseCommit=$(cat ./.buildinfo.enterprise-commit)\" " -o=bin/grafana-pro/linux/amd64/dynamic/grafana -trimpath -tags=osusergo,pro ./pkg/cmd/grafana; fi' 2024/05/14 11:13:15 Building with command 'if [ -d pkg/cmd/grafana-server ]; then go build -ldflags="-X \"main.version=10.1.0\" -X \"main.commit=$(cat ./.buildinfo.commit)\" -X \"main.buildBranch=$(cat ./.buildinfo.branch)\" -X \"main.enterpriseCommit=$(cat ./.buildinfo.enterprise-commit)\" " -o=bin/grafana-pro/linux/amd64/dynamic/grafana-server -trimpath -tags=osusergo,pro ./pkg/cmd/grafana-server; fi' 2024/05/14 11:13:15 Building with command 'if [ -d pkg/cmd/grafana-cli ]; then go build -ldflags="-X \"main.version=10.1.0\" -X \"main.commit=$(cat ./.buildinfo.commit)\" -X \"main.buildBranch=$(cat ./.buildinfo.branch)\" -X \"main.enterpriseCommit=$(cat ./.buildinfo.enterprise-commit)\" " -o=bin/grafana-pro/linux/amd64/dynamic/grafana-cli -trimpath -tags=osusergo,pro ./pkg/cmd/grafana-cli; fi' 2024/05/14 11:13:15 Building with command 'if [ -d pkg/cmd/grafana-example-apiserver ]; then go build -ldflags="-X \"main.version=10.1.0\" -X \"main.commit=$(cat ./.buildinfo.commit)\" -X \"main.buildBranch=$(cat ./.buildinfo.branch)\" -X \"main.enterpriseCommit=$(cat ./.buildinfo.enterprise-commit)\" " -o=bin/grafana-pro/linux/amd64/dynamic/grafana-example-apiserver -trimpath -tags=osusergo,pro ./pkg/cmd/grafana-example-apiserver; fi' time=2024-05-14T11:13:15.117Z level=INFO msg="done building directory" artifact=deb:pro:linux/amd64/dynamic filename=bin/grafana-pro/linux/amd64/dynamic service=ArtifactHandler time=2024-05-14T11:13:15.117Z level=INFO msg="getting dependencies..." artifact=10.1.0 filename=deb:pro:linux/amd64/dynamic/grafana-enterprise/public service=ArtifactHandler time=2024-05-14T11:13:15.117Z level=INFO msg="got dependencies" artifact=10.1.0 filename=deb:pro:linux/amd64/dynamic/grafana-enterprise/public service=ArtifactHandler count=0 time=2024-05-14T11:13:15.117Z level=INFO msg="getting builder..." artifact=10.1.0 filename=deb:pro:linux/amd64/dynamic/grafana-enterprise/public service=ArtifactHandler time=2024-05-14T11:13:57.427Z level=INFO msg="got builder" artifact=10.1.0 filename=deb:pro:linux/amd64/dynamic/grafana-enterprise/public service=ArtifactHandler time=2024-05-14T11:13:57.427Z level=INFO msg="building directory..." artifact=10.1.0 filename=deb:pro:linux/amd64/dynamic/grafana-enterprise/public service=ArtifactHandler time=2024-05-14T11:13:57.427Z level=INFO msg="done building directory" artifact=10.1.0 filename=deb:pro:linux/amd64/dynamic/grafana-enterprise/public service=ArtifactHandler time=2024-05-14T11:13:57.427Z level=INFO msg="getting dependencies..." artifact=deb:pro:linux/amd64/dynamic filename=10.1.0/npm-packages service=ArtifactHandler time=2024-05-14T11:13:57.427Z level=INFO msg="got dependencies" artifact=deb:pro:linux/amd64/dynamic filename=10.1.0/npm-packages service=ArtifactHandler count=0 time=2024-05-14T11:13:57.427Z level=INFO msg="getting builder..." artifact=deb:pro:linux/amd64/dynamic filename=10.1.0/npm-packages service=ArtifactHandler time=2024-05-14T11:13:57.490Z level=INFO msg="got builder" artifact=deb:pro:linux/amd64/dynamic filename=10.1.0/npm-packages service=ArtifactHandler time=2024-05-14T11:13:57.490Z level=INFO msg="building directory..." artifact=deb:pro:linux/amd64/dynamic filename=10.1.0/npm-packages service=ArtifactHandler time=2024-05-14T11:13:57.490Z level=INFO msg="done building directory" artifact=deb:pro:linux/amd64/dynamic filename=10.1.0/npm-packages service=ArtifactHandler time=2024-05-14T11:13:57.490Z level=INFO msg="getting dependencies..." artifact=deb:pro:linux/amd64/dynamic filename=bin/bundled-plugins service=ArtifactHandler time=2024-05-14T11:13:57.490Z level=INFO msg="got dependencies" artifact=deb:pro:linux/amd64/dynamic filename=bin/bundled-plugins service=ArtifactHandler count=0 time=2024-05-14T11:13:57.490Z level=INFO msg="getting builder..." artifact=deb:pro:linux/amd64/dynamic filename=bin/bundled-plugins service=ArtifactHandler time=2024-05-14T11:13:57.523Z level=INFO msg="got builder" artifact=deb:pro:linux/amd64/dynamic filename=bin/bundled-plugins service=ArtifactHandler time=2024-05-14T11:13:57.523Z level=INFO msg="building directory..." artifact=deb:pro:linux/amd64/dynamic filename=bin/bundled-plugins service=ArtifactHandler time=2024-05-14T11:13:57.523Z level=INFO msg="done building directory" artifact=deb:pro:linux/amd64/dynamic filename=bin/bundled-plugins service=ArtifactHandler time=2024-05-14T11:13:57.523Z level=INFO msg="getting dependencies..." artifact=deb:pro:linux/amd64/dynamic filename=10.1.0/storybook service=ArtifactHandler time=2024-05-14T11:13:57.523Z level=INFO msg="got dependencies" artifact=deb:pro:linux/amd64/dynamic filename=10.1.0/storybook service=ArtifactHandler count=0 time=2024-05-14T11:13:57.523Z level=INFO msg="getting builder..." artifact=deb:pro:linux/amd64/dynamic filename=10.1.0/storybook service=ArtifactHandler time=2024-05-14T11:13:57.545Z level=INFO msg="got builder" artifact=deb:pro:linux/amd64/dynamic filename=10.1.0/storybook service=ArtifactHandler time=2024-05-14T11:13:57.545Z level=INFO msg="building directory..." artifact=deb:pro:linux/amd64/dynamic filename=10.1.0/storybook service=ArtifactHandler time=2024-05-14T11:13:57.545Z level=INFO msg="done building directory" artifact=deb:pro:linux/amd64/dynamic filename=10.1.0/storybook service=ArtifactHandler time=2024-05-14T11:13:57.545Z level=INFO msg="getting builder..." artifact=deb:pro:linux/amd64/dynamic filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.tar.gz service=ArtifactHandler time=2024-05-14T11:13:57.545Z level=INFO msg="got builder" artifact=deb:pro:linux/amd64/dynamic filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.tar.gz service=ArtifactHandler time=2024-05-14T11:13:57.545Z level=INFO msg="building file..." artifact=deb:pro:linux/amd64/dynamic filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.tar.gz service=ArtifactHandler time=2024-05-14T11:13:57.545Z level=INFO msg="done building file" artifact=deb:pro:linux/amd64/dynamic filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.tar.gz service=ArtifactHandler time=2024-05-14T11:13:57.545Z level=INFO msg="getting builder..." artifact=deb:pro:linux/amd64/dynamic filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.deb service=ArtifactHandler time=2024-05-14T11:13:57.545Z level=INFO msg="got builder" artifact=deb:pro:linux/amd64/dynamic filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.deb service=ArtifactHandler time=2024-05-14T11:13:57.545Z level=INFO msg="building file..." artifact=deb:pro:linux/amd64/dynamic filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.deb service=ArtifactHandler time=2024-05-14T11:13:57.545Z level=INFO msg="done building file" artifact=deb:pro:linux/amd64/dynamic filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.deb service=ArtifactHandler time=2024-05-14T11:13:57.545Z level=INFO msg="Done adding artifact" filename=grafana-pro_10.1.0_12345_linux_amd64-dynamic.deb artifact=deb:pro:linux/amd64/dynamic time=2024-05-14T11:13:57.545Z level=INFO msg="Exporting artifacts..." time=2024-05-14T11:13:57.545Z level=INFO msg="Started exporting artifact..." artifact=deb:pro:linux/amd64/dynamic action=export time=2024-05-14T11:13:57.545Z level=INFO msg="Acquiring semaphore" artifact=deb:pro:linux/amd64/dynamic action=export time=2024-05-14T11:13:57.545Z level=INFO msg="Acquired semaphore" artifact=deb:pro:linux/amd64/dynamic action=export time=2024-05-14T11:13:57.545Z level=INFO msg="Exporting artifact" artifact=deb:pro:linux/amd64/dynamic action=export error exporting artifact 'grafana-pro_10.1.0_12345_linux_amd64-dynamic.deb': input: container.from.withExec.withExec.withExec.withExec.withExec.withExec.withExec.withEnvVariable.withEnvVariable.withEnvVariable.withEnvVariable.withEnvVariable.withEnvVariable.withEnvVariable.withEnvVariable.withDirectory.withDirectory.withDirectory.withDirectory.withFile.withDirectory.withDirectory.withDirectory.withFile.withFile.withWorkdir.withFile.withMountedCache.withFile.withFile.withFile.withExec.withExec.withExec.withExec.directory resolve: process "/bin/sh -c if [ -d pkg/cmd/grafana ]; then go build -ldflags=\"-X \\\"main.version=10.1.0\\\" -X \\\"main.commit=$(cat ./.buildinfo.commit)\\\" -X \\\"main.buildBranch=$(cat ./.buildinfo.branch)\\\" -X \\\"main.enterpriseCommit=$(cat ./.buildinfo.enterprise-commit)\\\" \" -o=bin/grafana-pro/linux/amd64/dynamic/grafana -trimpath -tags=osusergo,pro ./pkg/cmd/grafana; fi" did not complete successfully: exit code: 1 Stderr: # github.com/grafana/grafana/pkg/extensions/report/render pkg/extensions/report/render/task.go:117:4: unknown field CommonOpts in struct literal of type rendering.Opts pkg/extensions/report/render/task.go:117:26: undefined: rendering.CommonOpts pkg/extensions/report/render/task.go:136:4: unknown field CommonOpts in struct literal of type rendering.Opts pkg/extensions/report/render/task.go:136:26: undefined: rendering.CommonOpts pkg/extensions/report/render/task.go:155:4: unknown field CommonOpts in struct literal of type rendering.CSVOpts pkg/extensions/report/render/task.go:155:26: undefined: rendering.CommonOpts exit status 1 exit status 1
tomratcliffe commented 3 days ago

/deploy-to-hg

ephemeral-instances-bot[bot] commented 3 days ago
ephemeral-instances-bot[bot] commented 3 days ago