datatrails: reloaded trail bugs related to no selected metric

grafana / grafana

The open and composable observability and data visualization platform. Visualize metrics, logs, and traces from multiple sources like Prometheus, Loki, Elasticsearch, InfluxDB, Postgres and many more.

https://grafana.com

GNU Affero General Public License v3.0

60.72k stars 11.61k forks source link

datatrails: reloaded trail bugs related to no selected metric #87344

Closed darrenjaneczek closed 2 weeks ago

darrenjaneczek commented 2 weeks ago

Which issue(s) does this PR fix?:

The top scene was not being initialized when reloading trails, causing it to use the top scene of whatever was selected previously.
On reloading trails, any metric node that was 'green' with a undefined metric due to clicking on the "select new metric" button, was reloading with the metric of the step directly before it (in index order).

Special notes for your reviewer:

Please check that:

[ ] It works as expected from a user's perspective.
[ ] If this is a pre-GA feature, it is behind a feature toggle.
[ ] The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

grafana-delivery-bot[bot] commented 2 weeks ago

Hello @darrenjaneczek! Backport pull requests need to be either:

Pull requests which address bugs,
Urgent fixes which need product approval, in order to get merged,
Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label. If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label. If the pull request modifies CI behaviour, please add the type/ci label. If none of the above applies, please consider removing the backport label and target the next major/minor release. Thanks!