grafana / grafana

The open and composable observability and data visualization platform. Visualize metrics, logs, and traces from multiple sources like Prometheus, Loki, Elasticsearch, InfluxDB, Postgres and many more.
https://grafana.com
GNU Affero General Public License v3.0
65.3k stars 12.18k forks source link

Epic: Combobox - A new Select component #87959

Open joshhunt opened 6 months ago

joshhunt commented 6 months ago

Old Select related issues (which we aim to address with the New Select):

These tasks cover Act 1. Things intentionally not adressed here, as they will be adressed at a later date (Act 2):

### Tasks
- [x] Evaluate Downshift vs Floating UI for base
- [ ] https://github.com/grafana/grafana/issues/88897
- [ ] https://github.com/grafana/grafana/issues/88898
- [ ] https://github.com/grafana/grafana/issues/89412
- [ ] https://github.com/grafana/grafana/issues/90122
- [x] Loading/disabled/invalid states
- [ ] https://github.com/grafana/grafana/issues/90646
- [ ] https://github.com/grafana/grafana/issues/91255
- [ ] A11y testing
- [ ] https://github.com/grafana/grafana/issues/90645
- [ ] https://github.com/grafana/grafana/issues/91260
- [ ] https://github.com/grafana/grafana/issues/91259
- [ ] https://github.com/grafana/grafana/issues/92051
- [ ] https://github.com/grafana/grafana/issues/92396
- [ ] https://github.com/grafana/grafana/issues/93036
- [ ] https://github.com/grafana/grafana/issues/92404
- [ ] https://github.com/grafana/grafana/issues/93884
### Non-functional requirements
- [ ] Be FAST! for 1 million items (define "fast")
- [x] Must be accessible
- [x] Must work properly in modals and drawers (be portalled)
- [x] Must be easy to test
- [x] Menu placement should always be visible on the screen
### Known issues
- [ ] https://github.com/grafana/grafana/issues/91950
- [ ] https://github.com/grafana/grafana/issues/91952
- [ ] https://github.com/grafana/grafana/issues/92473
- [ ] https://github.com/grafana/grafana/issues/92586
- [ ] https://github.com/grafana/grafana/issues/92849
- [ ] https://github.com/grafana/grafana/issues/94467
- [ ] https://github.com/grafana/grafana/issues/95384
- [ ] https://github.com/grafana/grafana/issues/95385
- [ ] https://github.com/grafana/grafana/issues/95386
- [ ] https://github.com/grafana/grafana/issues/95567
- [ ] https://github.com/grafana/grafana/pull/95573
- [ ] Combobox: Gracefully degrade with many items berfore perfromance issues start
- [ ] https://github.com/grafana/grafana/pull/96458
tskarhed commented 4 months ago

For the Downshift vs Floating UI task, it doesn't really make sense, as Downshfit handles combobox functionality and Floating UI popover behavior.

tskarhed commented 4 months ago

Considerations: