grafana / grafana

The open and composable observability and data visualization platform. Visualize metrics, logs, and traces from multiple sources like Prometheus, Loki, Elasticsearch, InfluxDB, Postgres and many more.
https://grafana.com
GNU Affero General Public License v3.0
60.95k stars 11.63k forks source link

Alerting: separate out silence auth service preconditions checks #87998

Closed JacobsonMT closed 1 week ago

JacobsonMT commented 2 weeks ago

Will be useful for subsequent PR that adds metadata to silence response

What is this feature?

Separates out precondition checks from silence auth service AuthorizeXSilence methods.

Why do we need this feature?

This is so precondition checks can be used separately in a subsequent PR that will add permission metadata information to the GET silence responses.

Special notes for your reviewer:

This is mostly a no-op refactor but introduces a new short circuit for silence reads when a user has wildcard folder permissions.