Closed leonorfmartins closed 3 days ago
LGTM, some tests are failing though.
LGTM as well. Was there any discussion about what we might want to return? For instance, returning some kind of struct which provides a full accounting of which fields were a match and which ones were not?
What is this feature?
This PR introduces a comparator interface which will allow to compare returned objects from both stores and assert on its equality. This comparator can later be called on each dualwriter and its result pushed to metrics (defined here)
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Relates to https://github.com/grafana/search-and-storage-team/issues/37
Special notes for your reviewer:
Please check that: