search

grafana / grafana

The open and composable observability and data visualization platform. Visualize metrics, logs, and traces from multiple sources like Prometheus, Loki, Elasticsearch, InfluxDB, Postgres and many more.
https://grafana.com
GNU Affero General Public License v3.0
65.04k stars 12.14k forks source link

Explore profiles: Cant edit selected label values #93664

Closed tomershafir closed 1 month ago

tomershafir commented 1 month ago

What happened?

After I insert a label value into a filter on Explore Profiles plugin, I can't edit that value. It requires to rewrite it, which is bad UX I think.

What did you expect to happen?

Enable to edit a selected label value.

Did this work before?

No

How do we reproduce it?

  1. Open Explore Profiles>labels tab
  2. Add label filter and select a label value
  3. Try to edit the label value

Is the bug inside a dashboard panel?

No response

Environment (with versions)?

Grafana: 11.2.0 Plugin: 0.1.9

Grafana platform?

Kubernetes

Datasource(s)?

No response

grafakus commented 1 month ago

Hi @tomershafir, thank you for reporting.

AFAIK it has always worked... Here's a short video:

https://github.com/user-attachments/assets/f6465887-e091-47cd-bbe5-e71bb3105f74

tomershafir commented 1 month ago

Let me clarify - I expect to be able to edit the value in place. Right now, you can only replace a value, rather than mutate in place. In case of a complex regex for example, its hard to use: it requires to use an external tool to avoid recurring complete rewrites, and results in slower feedback loops.

grafakus commented 1 month ago

Thank for the clarification! You can only replace the value because the operator is =, which expects an exact value chosen from the list of values.

For regexes, have you tried the regex operator =~?

tomershafir commented 1 month ago

I experience the same behavior with =~ on plugin version 0.1.11

grafakus commented 1 month ago

I see. Indeed this is how the Select component from the design system works with custom values. Let me move this issue to the Explore Profiles repository.

Related: https://github.com/grafana/grafana/issues/73528

grafakus commented 1 month ago

Will be fixed by https://github.com/grafana/explore-profiles/issues/206