search

grafana / grafonnet-lib

Jsonnet library for generating Grafana dashboard files.
https://grafana.github.io/grafonnet-lib/
Apache License 2.0
1.08k stars 217 forks source link

Add support for timeseries panels #362

Closed rhowe closed 1 year ago

rhowe commented 2 years ago

This is based on the behaviour of Grafana 9.0.5

It should address https://github.com/grafana/grafonnet-lib/issues/358 and https://github.com/grafana/grafonnet-lib/issues/352

Upgrade the e2e tests to work with Grafana 9.x

Fixes https://github.com/grafana/grafonnet-lib/issues/363

Note that I haven't used cypress before and I work hard to avoid node, so this might not be quite right.

I added a Makefile target for running npm install to allow upgrading Cypress without relying on a local Nodejs install.

Somehow I missed the fact the repo had tests until I was too far down the rabbit hole writing the tests in a different style, hope that's OK.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

rhowe commented 2 years ago

@malcolmholmes sorry to be a pain, and I know grafonnet isn't exactly an active project these days but what are the chances of this PR getting a review?

nickkjolsing commented 2 years ago

@rhowe Agreed, I would absolutely love having timeseries compatibility :)

joaosa commented 2 years ago

@malcolmholmes same here! this would be incredibly useful

rhowe commented 2 years ago

If you want this, please don't continue to spam a Grafana engineer with comments (yes, OK, I know, I started it, but we don't all need to do it). Just add a :+1: to the MR

Also there's nothing stopping you taking the code from my branch and using it yourself, even if it's not in the main grafonnet repo.

malcolmholmes commented 1 year ago

See new README. This repo is deprecated. The new Grafonnet has support for the timeseries panel (https://github.com/grafana/grafonnet)