search

grafana / grafonnet

Jsonnet library for generating Grafana dashboards.
https://grafana.github.io/grafonnet/
Apache License 2.0
322 stars 19 forks source link

Add dependency check to Makefile #124

Open Aurelian-Shuttleworth opened 9 months ago

Aurelian-Shuttleworth commented 9 months ago

A new Bash script dependancy_check.sh has been added to ensure that the minimum required Bash version is used and that required commands used by generate are available. This script is now called in the Makefile as part of the check_dependencies task. This aims to prevent errors due to incompatible Bash versions or missing commands.

After encountering some minor inconvenience debugging why then generate.sh script was failing, I added this script to ensure others don't waste any time.

Also, minor clean up of the Development readme.

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

Duologic commented 9 months ago

Thanks of this, the DEVELOPMENT.md is totally out-of-date and requires a proper rewrite, perhaps we can do that in a separate PR.

Duologic commented 9 months ago

I've made updates to the Makefile in #129 and rewritten DEVELOPMENT.md in #133, please have a look at these.

Duologic commented 9 months ago

I've been thinking about this, perhaps it would be much safer to pour this all into a container image rather than expecting a local development environment. WDYT?

Aurelian-Shuttleworth commented 7 months ago

@Duologic I agree moving to a dev container would be a much better way to handle it.

May I suggest creating a Dev container or multiple?

Plus makes for great integration in most popular IDE.