grafana / grafonnet

Jsonnet library for generating Grafana dashboards.
https://grafana.github.io/grafonnet/
Apache License 2.0
352 stars 19 forks source link

feat: release v10.2.0 as latest #156

Closed jan-xyz closed 8 months ago

jan-xyz commented 9 months ago

fixes: #150

I had to uncomment withStyle as this doesn't exist anymore for v10.2.0 dashboards. This probably breaks backwards compatibility with previous versions. Do you have a better idea on how to handle that? I also had to switch the script from jrsonnet to jsonnet since that tool had problems with the any property in the custom boards. I am not sure if I was using simply the wrong tool or if there is something else going on. I can simply revert that specific commit if it is a problem on my side.

I suggest to look commit-by-commit.

tools used:

❯ jrsonnet --version
jrsonnet 0.4.2
❯ jsonnet --version
Jsonnet commandline interpreter (Go implementation) v0.20.0
❯ bash --version
GNU bash, version 5.2.21(1)-release (aarch64-apple-darwin23.0.0)
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

jan-xyz commented 9 months ago

Can you also regenerate the other versions? This should only remove the withStyle function.

Hmmm, it seems like it also changes the type annotations from type: foo to type: [foo]

-  '#withName': { 'function': { args: [{ default: null, enums: null, name: 'value', type: 'string' }], help: '' } },
+  '#withName': { 'function': { args: [{ default: null, enums: null, name: 'value', type: ['string'] }], help: '' } },
Duologic commented 9 months ago

Type was changed in #154, can you rebase?

jan-xyz commented 9 months ago

regenerating is done, and as you said no changes but the removal of withStyle

Duologic commented 8 months ago

Ugh, sorry, #159 got merged and is causing a conflict. Can you rebase?